update test data for node 18 lts release #2933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just to get the CI working first, I don't think it's a good test though. |
Member
|
This will fail, because Travis is on xenial which can’t build node 18. If you can help install the right C libs on Xenial, that would unblock this :-) |
Contributor
Author
Hmmm, that's way more than I had expected, not sure if I could figure that out but I think that will require a separate PR or something? |
Member
|
I think this PR should end up containing that fix. It's definitely a much larger change. |
Member
|
I've updated this with a commit that runs the "update test mocks" script (and fixed tests on master) |
ljharb
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lts/galliumis node 16, whilelts/hydrogenis node 18.This fixes the following test: